-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 Add update-csv
when make update
#238
🌱 Add update-csv
when make update
#238
Conversation
Signed-off-by: xuezhaojun <zxue@redhat.com>
/assign @qiujian16 |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #238 +/- ##
==========================================
+ Coverage 60.29% 60.31% +0.01%
==========================================
Files 131 131
Lines 13543 13538 -5
==========================================
- Hits 8166 8165 -1
+ Misses 4625 4621 -4
Partials 752 752
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
/retest |
/approve would you also add a TODO to verify the csv? |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: qiujian16, xuezhaojun The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Agree, I will add csv verification in the "make verify-crds" later. |
Summary
This is a issue when I tried to update Kluterlet in this PR: #234
We run
make update
to use the latest version of Klusterlet, but then the integration-test fails because it depends on the following file:ocm/test/integration/operator/integration_suite_test.go
Line 82 in e810520
And this file needs to update by the
make update-csv
command.So it's better to combine 2 commands.