Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 Use finalizer in api repo #241

Merged

Conversation

qiujian16
Copy link
Member

Summary

Related issue(s)

Fixes #

@openshift-ci openshift-ci bot requested review from elgnay and ldpliu August 1, 2023 07:57
@openshift-ci openshift-ci bot added the approved label Aug 1, 2023
@codecov
Copy link

codecov bot commented Aug 1, 2023

Codecov Report

Patch coverage: 41.66% and project coverage change: +0.02% 🎉

Comparison is base (6d6a6f1) 60.35% compared to head (df0112a) 60.37%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #241      +/-   ##
==========================================
+ Coverage   60.35%   60.37%   +0.02%     
==========================================
  Files         132      132              
  Lines       13590    13590              
==========================================
+ Hits         8202     8205       +3     
+ Misses       4633     4632       -1     
+ Partials      755      753       -2     
Flag Coverage Δ
unit 60.37% <41.66%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...lers/klusterletcontroller/klusterlet_controller.go 69.54% <ø> (ø)
...usterletcontroller/klusterlet_managed_reconcile.go 52.88% <0.00%> (ø)
...gistration/hub/rbacfinalizerdeletion/controller.go 61.94% <0.00%> (ø)
...izercontroller/manifestwork_finalize_controller.go 49.27% <0.00%> (ø)
...ers/statuscontroller/availablestatus_controller.go 74.34% <0.00%> (ø)
...troller/appliedmanifestwork_finalize_controller.go 42.42% <50.00%> (ø)
...lers/manifestcontroller/manifestwork_controller.go 64.13% <50.00%> (ø)
pkg/registration/hub/managedcluster/controller.go 52.00% <100.00%> (ø)
...rs/finalizercontroller/add_finalizer_controller.go 28.57% <100.00%> (ø)

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Jian Qiu <jqiu@redhat.com>
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 3, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qiujian16

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@skeeey
Copy link
Member

skeeey commented Aug 4, 2023

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Aug 4, 2023
@openshift-merge-robot openshift-merge-robot merged commit 3167826 into open-cluster-management-io:main Aug 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants