Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 add wlp annotation if necessary #248

Conversation

elgnay
Copy link
Contributor

@elgnay elgnay commented Aug 7, 2023

Summary

Related issue(s)

Fixes #

@openshift-ci openshift-ci bot requested review from zhiweiyin318 and zhujian7 August 7, 2023 09:47
@elgnay elgnay force-pushed the ensure-wlp-annotation branch from 925e8d5 to 3cea8cb Compare August 7, 2023 09:53
@codecov
Copy link

codecov bot commented Aug 7, 2023

Codecov Report

Patch coverage: 72.22% and project coverage change: +0.01% 🎉

Comparison is base (3167826) 60.35% compared to head (346efda) 60.37%.
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #248      +/-   ##
==========================================
+ Coverage   60.35%   60.37%   +0.01%     
==========================================
  Files         132      132              
  Lines       13590    13652      +62     
==========================================
+ Hits         8202     8242      +40     
- Misses       4634     4651      +17     
- Partials      754      759       +5     
Flag Coverage Δ
unit 60.37% <72.22%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...sterletcontroller/klusterlet_cleanup_controller.go 55.10% <0.00%> (ø)
...controllers/klusterletcontroller/client_builder.go 57.77% <50.00%> (+0.95%) ⬆️
...lers/klusterletcontroller/klusterlet_controller.go 67.11% <75.00%> (-2.44%) ⬇️
...usterletcontroller/klusterlet_managed_reconcile.go 52.88% <100.00%> (ø)
...terletcontroller/klusterlet_management_recocile.go 52.45% <100.00%> (ø)

... and 19 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@elgnay elgnay force-pushed the ensure-wlp-annotation branch 2 times, most recently from 37115f8 to bd9c0ba Compare August 8, 2023 03:08
@elgnay elgnay force-pushed the ensure-wlp-annotation branch 2 times, most recently from 43355c3 to ce54ef4 Compare August 16, 2023 09:04
Signed-off-by: Yang Le <yangle@redhat.com>
@elgnay elgnay force-pushed the ensure-wlp-annotation branch from ce54ef4 to 346efda Compare August 16, 2023 09:22
Copy link
Member

@qiujian16 qiujian16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 17, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: elgnay, qiujian16

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit f444b34 into open-cluster-management-io:main Aug 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants