Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 fix the rebootstrap issue #249

Merged

Conversation

elgnay
Copy link
Contributor

@elgnay elgnay commented Aug 8, 2023

Summary

Related issue(s)

Fixes #

@codecov
Copy link

codecov bot commented Aug 8, 2023

Codecov Report

Patch coverage: 75.36% and project coverage change: +0.07% 🎉

Comparison is base (3167826) 60.35% compared to head (b4ea047) 60.42%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #249      +/-   ##
==========================================
+ Coverage   60.35%   60.42%   +0.07%     
==========================================
  Files         132      132              
  Lines       13590    13639      +49     
==========================================
+ Hits         8202     8242      +40     
- Misses       4634     4640       +6     
- Partials      754      757       +3     
Flag Coverage Δ
unit 60.42% <75.36%> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
pkg/operator/helpers/helpers.go 61.75% <ø> (ø)
...rollers/bootstrapcontroller/bootstrapcontroller.go 50.96% <73.01%> (+6.17%) ⬆️
...usterletcontroller/klusterlet_runtime_reconcile.go 58.15% <100.00%> (+1.22%) ⬆️

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@elgnay elgnay closed this Aug 8, 2023
@elgnay elgnay reopened this Aug 8, 2023
@elgnay elgnay closed this Aug 8, 2023
@elgnay elgnay reopened this Aug 8, 2023
Signed-off-by: Yang Le <yangle@redhat.com>
@qiujian16
Copy link
Member

/approve
/lgtm

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 15, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: elgnay, qiujian16

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 8080e5d into open-cluster-management-io:main Aug 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants