Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Revert "Fix PodSecurity Warnings" #252

Merged

Conversation

zhiweiyin318
Copy link
Member

This reverts commit ecc541d.

Summary

Related issue(s)

Fixes #

This reverts commit ecc541d.

Signed-off-by: Zhiwei Yin <zyin@redhat.com>
@zhiweiyin318 zhiweiyin318 changed the title Revert "Fix PodSecurity Warnings (#250)" 🐛 Revert "Fix PodSecurity Warnings (#250)" Aug 21, 2023
@zhiweiyin318 zhiweiyin318 reopened this Aug 21, 2023
@codecov
Copy link

codecov bot commented Aug 21, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.02% ⚠️

Comparison is base (ecc541d) 60.39% compared to head (d4ec48c) 60.37%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #252      +/-   ##
==========================================
- Coverage   60.39%   60.37%   -0.02%     
==========================================
  Files         132      132              
  Lines       13652    13658       +6     
==========================================
+ Hits         8245     8246       +1     
- Misses       4649     4654       +5     
  Partials      758      758              
Flag Coverage Δ
unit 60.37% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@xuezhaojun
Copy link
Member

xuezhaojun commented Aug 21, 2023

@zhiweiyin318 @qiujian16 Do we consider to do a fix instead of a revert? That means we only remove the seccompProfile but leave the rest part there including runAsNonRoot , allowPrivilegeEscalation etc.

These fields have values to be added. We just need to handle the special case cased by seccompProfile.

@zhiweiyin318 zhiweiyin318 changed the title 🐛 Revert "Fix PodSecurity Warnings (#250)" 🐛 Revert "Fix PodSecurity Warnings" Aug 21, 2023
@qiujian16
Copy link
Member

let's do revert at first to avoid breaking the e2e. We need an approach to solve ssc anyway later
/approve
/lgtm

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 21, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qiujian16, zhiweiyin318

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 4227c8f into open-cluster-management-io:main Aug 21, 2023
18 of 23 checks passed
@zhiweiyin318 zhiweiyin318 deleted the revert-250 branch August 21, 2023 05:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants