🐛 revert placement decision start index from 1 to keep backward compatibility #253
Conversation
|
/hold |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #253 +/- ##
=======================================
Coverage 60.37% 60.38%
=======================================
Files 132 132
Lines 13658 13660 +2
=======================================
+ Hits 8246 8248 +2
+ Misses 4654 4653 -1
- Partials 758 759 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
haoqing0110
force-pushed
the
br_placement-decision
branch
from
5ed14c4 to
a8cdcee
Compare
haoqing0110
force-pushed
the
br_placement-decision
branch
from
a8cdcee to
aa9e977
Compare
|
/assign @qiujian16 |
| @@ -465,7 +465,8 @@ func (c *schedulingController) generatePlacementDecisionsAndStatus( | |||
|
|
|||
| // generate placement decision for each decision group | |||
| for decisionGroupIndex, decisionGroup := range decisionGroups { | |||
| // generate placement decisions and status, group and placement name index starts from 0. | |||
| // generate placement decisions and status, group name index starts from 0, placement name index | |||
| // starts from 1 to keep backward compatibility. | |||
There was a problem hiding this comment.
add a todo here, we should be consistent with index or using a random generate name when version bumps
…bility Signed-off-by: haoqing0110 <qhao@redhat.com>
haoqing0110
force-pushed
the
br_placement-decision
branch
from
aa9e977 to
e9e702a
Compare
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: haoqing0110, qiujian16 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/unhold |
Summary
Related issue(s)
Fixes #