-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 adding contextual logging in placement component #254
🌱 adding contextual logging in placement component #254
Conversation
Signed-off-by: ntishchauhan0022 <nitishchauhan0022@gmail.com>
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #254 +/- ##
=======================================
Coverage 60.37% 60.37%
=======================================
Files 132 132
Lines 13658 13667 +9
=======================================
+ Hits 8246 8252 +6
- Misses 4654 4656 +2
- Partials 758 759 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
/assign @haoqing0110 |
@xuezhaojun: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
f2a7d37
to
e8cd188
Compare
/lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: nitishchauhan0022, qiujian16 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Summary
Adding contextual logging
Related issue(s)
Fixes #191
For More Info:
https://www.kubernetes.dev/blog/2022/05/25/contextual-logging/
https://github.com/kubernetes/community/blob/master/contributors/devel/sig-instrumentation/migration-to-structured-logging.md