Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 adding contextual logging in placement component #254

Conversation

nitishchauhan0022
Copy link
Contributor

Signed-off-by: ntishchauhan0022 <nitishchauhan0022@gmail.com>
@openshift-ci openshift-ci bot requested review from elgnay and haoqing0110 August 22, 2023 17:05
@codecov
Copy link

codecov bot commented Aug 22, 2023

Codecov Report

Patch coverage: 46.15% and no project coverage change.

Comparison is base (4227c8f) 60.37% compared to head (f2a7d37) 60.37%.
Report is 1 commits behind head on main.

❗ Current head f2a7d37 differs from pull request most recent head e8cd188. Consider uploading reports for the commit e8cd188 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #254   +/-   ##
=======================================
  Coverage   60.37%   60.37%           
=======================================
  Files         132      132           
  Lines       13658    13667    +9     
=======================================
+ Hits         8246     8252    +6     
- Misses       4654     4656    +2     
- Partials      758      759    +1     
Flag Coverage Δ
unit 60.37% <46.15%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
pkg/placement/controllers/scheduling/schedule.go 67.88% <12.50%> (-0.81%) ⬇️
pkg/placement/controllers/scheduling/enqueue.go 61.21% <55.55%> (+0.23%) ⬆️
...nt/controllers/scheduling/scheduling_controller.go 67.40% <60.00%> (+0.24%) ⬆️
...cement/plugins/tainttoleration/taint_toleration.go 79.41% <66.66%> (ø)
pkg/placement/plugins/addon/addon.go 64.15% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@qiujian16
Copy link
Member

/assign @haoqing0110

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 23, 2023

@xuezhaojun: Closed this PR.

In response to this:

/Close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot closed this Aug 23, 2023
@xuezhaojun xuezhaojun reopened this Aug 23, 2023
@nitishchauhan0022 nitishchauhan0022 force-pushed the contextual-logging-placement branch from f2a7d37 to e8cd188 Compare August 23, 2023 18:07
@haoqing0110
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Aug 24, 2023
@qiujian16
Copy link
Member

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 25, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nitishchauhan0022, qiujian16

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 36e389c into open-cluster-management-io:main Aug 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

use contextual logging in ocm
5 participants