Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 adding contextual logging in addon pkg #255

Conversation

nitishchauhan0022
Copy link
Contributor

Signed-off-by: ntishchauhan0022 <nitishchauhan0022@gmail.com>
@codecov
Copy link

codecov bot commented Aug 22, 2023

Codecov Report

Patch coverage: 80.00% and project coverage change: +0.05% 🎉

Comparison is base (4227c8f) 60.37% compared to head (17271d6) 60.42%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #255      +/-   ##
==========================================
+ Coverage   60.37%   60.42%   +0.05%     
==========================================
  Files         132      132              
  Lines       13658    13688      +30     
==========================================
+ Hits         8246     8271      +25     
- Misses       4654     4657       +3     
- Partials      758      760       +2     
Flag Coverage Δ
unit 60.42% <80.00%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...kg/addon/controllers/addonmanagement/controller.go 0.00% <0.00%> (ø)
...addon/controllers/addonconfiguration/controller.go 32.75% <50.00%> (+0.30%) ⬆️
pkg/addon/controllers/addontemplate/controller.go 66.40% <50.00%> (-0.81%) ⬇️
...g/addon/controllers/addonprogressing/controller.go 68.61% <80.00%> (+0.16%) ⬆️
pkg/addon/templateagent/template_agent.go 58.18% <90.90%> (+2.84%) ⬆️
...ollers/addonmanagement/addon_install_reconciler.go 70.83% <100.00%> (+0.83%) ⬆️
pkg/addon/controllers/addonowner/controller.go 64.15% <100.00%> (+0.68%) ⬆️
...rs/managementaddoninstallprogression/controller.go 67.40% <100.00%> (ø)
pkg/addon/templateagent/registration.go 56.81% <100.00%> (+0.87%) ⬆️
pkg/addon/templateagent/values.go 81.25% <100.00%> (+0.60%) ⬆️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@qiujian16
Copy link
Member

/assign @zhujian7

@zhujian7
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Aug 24, 2023
@qiujian16
Copy link
Member

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 24, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nitishchauhan0022, qiujian16

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 9dd935b into open-cluster-management-io:main Aug 24, 2023
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

use contextual logging in ocm
4 participants