✨ support singleton in hosted mode #258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: qiujian16 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
qiujian16
force-pushed
the
handle-upgrade
branch
2 times, most recently
from
2c8e8ad to
16d4e9c
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #258 +/- ##
==========================================
- Coverage 60.71% 60.70% -0.01%
==========================================
Files 128 128
Lines 13666 13676 +10
==========================================
+ Hits 8297 8302 +5
- Misses 4603 4608 +5
Partials 766 766
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
qiujian16
force-pushed
the
handle-upgrade
branch
from
16d4e9c to
fe3897f
Compare
qiujian16
force-pushed
the
handle-upgrade
branch
from
fe3897f to
a942e9b
Compare
qiujian16
force-pushed
the
handle-upgrade
branch
5 times, most recently
from
73b26bf to
a72fd54
Compare
qiujian16
changed the title
Signed-off-by: Jian Qiu <jqiu@redhat.com>
Signed-off-by: Jian Qiu <jqiu@redhat.com>
qiujian16
force-pushed
the
handle-upgrade
branch
from
a72fd54 to
4b91426
Compare
zhujian7
reviewed
Sep 6, 2023
| {{if eq .InstallMode "SingletonHosted"}} | ||
| - name: spoke-kubeconfig-secret | ||
| secret: | ||
| secretName: {{ .ExternalManagedKubeConfigWorkSecret }} |
There was a problem hiding this comment.
for singletonHosted mode, will it still generate two(external registration/work) secrets? why use the work secret here?
There was a problem hiding this comment.
yeah, it is a bit confusing. Updated and add some comment.
Signed-off-by: Jian Qiu <jqiu@redhat.com>
qiujian16
force-pushed
the
handle-upgrade
branch
from
fc4f3e6 to
0b7a2b9
Compare
|
/LGTM |
openshift-merge-robot
merged commit 404680d
into
open-cluster-management-io:main
12 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Related issue(s)
Fixes #