Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ support proxy between hub cluster and managed cluster #260

Merged

Conversation

elgnay
Copy link
Contributor

@elgnay elgnay commented Aug 31, 2023

Summary

Allow user to configure proxy settings in bootstrap hub kubeconfig.

Related issue(s)

Fixes #

@codecov
Copy link

codecov bot commented Aug 31, 2023

Codecov Report

Patch coverage: 36.36% and project coverage change: +0.26% 🎉

Comparison is base (36e389c) 60.44% compared to head (5cccebe) 60.70%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #260      +/-   ##
==========================================
+ Coverage   60.44%   60.70%   +0.26%     
==========================================
  Files         132      128       -4     
  Lines       13694    13640      -54     
==========================================
+ Hits         8277     8280       +3     
+ Misses       4657     4596      -61     
- Partials      760      764       +4     
Flag Coverage Δ
unit 60.70% <36.36%> (+0.26%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
pkg/registration/spoke/spokeagent.go 14.32% <19.23%> (+0.49%) ⬆️
...rollers/bootstrapcontroller/bootstrapcontroller.go 51.19% <100.00%> (+0.23%) ⬆️
pkg/registration/clientcert/certificate.go 54.80% <100.00%> (+12.18%) ⬆️

... and 6 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@elgnay elgnay force-pushed the proxy-support branch 3 times, most recently from 5c7a0e2 to af7299d Compare August 31, 2023 06:20
@qiujian16
Copy link
Member

/approve

would you also check the codecov? it seems it reduces a bit

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 31, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: elgnay, qiujian16

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Member

@xuezhaojun xuezhaojun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@xuezhaojun
Copy link
Member

xuezhaojun commented Aug 31, 2023

/hold

Looks clear and good to me! feel free to unhold if no another update.

Signed-off-by: Yang Le <yangle@redhat.com>
@qiujian16
Copy link
Member

/lgtm

@xuezhaojun
Copy link
Member

/lgtm

@elgnay
Copy link
Contributor Author

elgnay commented Sep 1, 2023

/unhold

@openshift-merge-robot openshift-merge-robot merged commit ac142e6 into open-cluster-management-io:main Sep 1, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants