🐛 correct the agent deployment name in different install mode #265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/assign @qiujian16 |
elgnay
force-pushed
the
fix-agent-name
branch
from
895bbf4 to
03ef372
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #265 +/- ##
=======================================
Coverage 60.71% 60.71%
=======================================
Files 128 128
Lines 13658 13666 +8
=======================================
+ Hits 8292 8297 +5
- Misses 4601 4603 +2
- Partials 765 766 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
qiujian16
reviewed
Sep 5, 2023
pkg/operator/operators/klusterlet/controllers/bootstrapcontroller/bootstrapcontroller.go
Outdated
Show resolved
Hide resolved
elgnay
force-pushed
the
fix-agent-name
branch
from
03ef372 to
35f06b2
Compare
Signed-off-by: Yang Le <yangle@redhat.com>
elgnay
force-pushed
the
fix-agent-name
branch
from
35f06b2 to
01343a9
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: elgnay, qiujian16 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-robot
merged commit 7adf6ee
into
open-cluster-management-io:main
12 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Related issue(s)
Fixes #