🌱 bump golangci-lint to v1.54.2 #270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: zhujian <jiazhu@redhat.com>
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #270 +/- ##
==========================================
+ Coverage 60.68% 60.71% +0.02%
==========================================
Files 128 128
Lines 13676 13678 +2
==========================================
+ Hits 8299 8304 +5
+ Misses 4610 4608 -2
+ Partials 767 766 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: qiujian16, zhujian7 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-robot
merged commit e0d1ad3
into
open-cluster-management-io:main
12 checks passed
morvencao
pushed a commit
to morvencao/OCM
that referenced
this pull request
Sep 8, 2023
open-cluster-management-io#270) * update serverURL and CABundle if ManagedCluster is created before registration-agent running Signed-off-by: ivan-cai <caijing.cai@alibaba-inc.com> * merge spokeExternalServerURLs to ManagedClusterClientConfigs, and ingnore Unauthorized error Signed-off-by: ivan-cai <caijing.cai@alibaba-inc.com> * add comment for skipping unauthorized error, and skip unauthorized error when creating ManagedCluster Signed-off-by: ivan-cai <caijing.cai@alibaba-inc.com> * use skipUnauthorizedError at creating controller Signed-off-by: ivan-cai <caijing.cai@alibaba-inc.com> Signed-off-by: ivan-cai <caijing.cai@alibaba-inc.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Related issue(s)
Fixes #