🐛 Match registration image exactly #273
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since the registration image string is a substring of the registration-operator image, it wasn't being updated correctly. Signed-off-by: Dale Haiducek <19750917+dhaiducek@users.noreply.github.com>
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #273 +/- ##
=======================================
Coverage 60.71% 60.71%
=======================================
Files 128 128
Lines 13678 13678
=======================================
Hits 8304 8304
+ Misses 4609 4608 -1
- Partials 765 766 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
mprahl
approved these changes
Sep 8, 2023
|
/lgtm |
|
/assign @qiujian16 |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dhaiducek, mprahl, qiujian16 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-robot
merged commit 3fc013f
into
open-cluster-management-io:main
12 checks passed
TomerFi
pushed a commit
to TomerFi/OCM
that referenced
this pull request
Sep 27, 2023
…ent-io#273) Signed-off-by: zhujian <jiazhu@redhat.com> Signed-off-by: zhujian <jiazhu@redhat.com>
TomerFi
pushed a commit
to TomerFi/OCM
that referenced
this pull request
Sep 27, 2023
Signed-off-by: ldpliu <daliu@redhat.com> Signed-off-by: ldpliu <daliu@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Since the registration image string is a substring of the registration-operator image, it wasn't being updated correctly. Adding a trailing
$to match the end of the line fixes this for me locally.Related issue(s)
Fixes #