Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weā€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

šŸ› fix the AlreadyExists logic if the manifest is not cached by Gā€¦ #275

Conversation

elgnay
Copy link
Contributor

@elgnay elgnay commented Sep 11, 2023

ā€¦etter when applying a manifest

Summary

Related issue(s)

Fixes #

@codecov
Copy link

codecov bot commented Sep 11, 2023

Codecov Report

Patch coverage: 78.57% and project coverage change: +0.02% šŸŽ‰

Comparison is base (3fc013f) 60.71% compared to head (da6e1ec) 60.73%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #275      +/-   ##
==========================================
+ Coverage   60.71%   60.73%   +0.02%     
==========================================
  Files         128      128              
  Lines       13678    13685       +7     
==========================================
+ Hits         8304     8311       +7     
+ Misses       4609     4608       -1     
- Partials      765      766       +1     
Flag Coverage Ī”
unit 60.73% <78.57%> (+0.02%) ā¬†ļø

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Ī”
pkg/common/apply/interface.go 77.27% <78.57%> (+4.29%) ā¬†ļø

... and 1 file with indirect coverage changes

ā˜” View full report in Codecov by Sentry.
šŸ“¢ Have feedback on the report? Share it here.

@elgnay elgnay force-pushed the fix-already-exists-logic branch from 83620ba to 2d520a2 Compare September 11, 2023 07:38
@qiujian16
Copy link
Member

/approve

only thing is I think we need to add a comment

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 11, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: elgnay, qiujian16

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

ā€¦etter when applying a manifest

Signed-off-by: Yang Le <yangle@redhat.com>
@elgnay elgnay force-pushed the fix-already-exists-logic branch from 2d520a2 to da6e1ec Compare September 11, 2023 08:29
@elgnay elgnay changed the title šŸ› fix the AlreadyExists logic case if the manifest is not cached by Gā€¦ šŸ› fix the AlreadyExists logic if the manifest is not cached by Gā€¦ Sep 11, 2023
@haoqing0110
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Sep 11, 2023
@openshift-merge-robot openshift-merge-robot merged commit 1f51d8c into open-cluster-management-io:main Sep 11, 2023
13 checks passed
@zhujian7
Copy link
Member

/lgtm

TomerFi pushed a commit to TomerFi/OCM that referenced this pull request Sep 27, 2023
ā€¦nt-io#275)

Signed-off-by: zhujian <jiazhu@redhat.com>

Signed-off-by: zhujian <jiazhu@redhat.com>
TomerFi pushed a commit to TomerFi/OCM that referenced this pull request Sep 27, 2023
ā€¦ment-io#275)

Signed-off-by: Wei Liu <liuweixa@redhat.com>

Signed-off-by: Wei Liu <liuweixa@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants