Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 fix work sa name in old kube cluster #281

Conversation

zhiweiyin318
Copy link
Member

Summary

Related issue(s)

Fixes #

@openshift-ci openshift-ci bot requested review from deads2k and jnpacker September 18, 2023 07:17
@qiujian16
Copy link
Member

/approve
/lgtm

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 18, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qiujian16, zhiweiyin318

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov
Copy link

codecov bot commented Sep 18, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.03% ⚠️

Comparison is base (bd4982f) 61.03% compared to head (22ba33c) 61.01%.

❗ Current head 22ba33c differs from pull request most recent head fc60410. Consider uploading reports for the commit fc60410 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #281      +/-   ##
==========================================
- Coverage   61.03%   61.01%   -0.03%     
==========================================
  Files         128      128              
  Lines       13719    13719              
==========================================
- Hits         8374     8371       -3     
- Misses       4579     4582       +3     
  Partials      766      766              
Flag Coverage Δ
unit 61.01% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@openshift-ci openshift-ci bot removed the lgtm label Sep 18, 2023
@zhiweiyin318 zhiweiyin318 force-pushed the fix-311-work branch 2 times, most recently from a98a12b to 22ba33c Compare September 18, 2023 09:17
Signed-off-by: Zhiwei Yin <zyin@redhat.com>
@qiujian16
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Sep 18, 2023
@openshift-merge-robot openshift-merge-robot merged commit b6f535f into open-cluster-management-io:main Sep 18, 2023
12 checks passed
@zhiweiyin318 zhiweiyin318 deleted the fix-311-work branch September 18, 2023 10:32
TomerFi pushed a commit to TomerFi/OCM that referenced this pull request Sep 27, 2023
Signed-off-by: haoqing0110 <qhao@redhat.com>

Signed-off-by: haoqing0110 <qhao@redhat.com>
TomerFi pushed a commit to TomerFi/OCM that referenced this pull request Sep 27, 2023
…ion (open-cluster-management-io#281)

Signed-off-by: Jian Qiu <jqiu@redhat.com>

Signed-off-by: Jian Qiu <jqiu@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants