Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 set work agent status-sync-interval when the replica is 1 #282

Merged

Conversation

zhujian7
Copy link
Member

Summary

Related issue(s)

Fixes #

@zhujian7
Copy link
Member Author

/hold

@codecov
Copy link

codecov bot commented Sep 18, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (bd4982f) 61.03% compared to head (0e0069b) 61.03%.
Report is 5 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #282   +/-   ##
=======================================
  Coverage   61.03%   61.03%           
=======================================
  Files         128      128           
  Lines       13719    13719           
=======================================
  Hits         8374     8374           
- Misses       4579     4580    +1     
+ Partials      766      765    -1     
Flag Coverage Δ
unit 61.03% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zhujian7 zhujian7 changed the title ❓ set work agent status-sync-interval when the replica is 1 🌱 set work agent status-sync-interval when the replica is 1 Sep 18, 2023
Signed-off-by: zhujian <jiazhu@redhat.com>
@zhujian7
Copy link
Member Author

/cc @qiujian16 @elgnay

@openshift-ci openshift-ci bot requested review from elgnay and qiujian16 September 20, 2023 01:22
@qiujian16
Copy link
Member

/approve
/lgtm

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 20, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qiujian16, zhujian7

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@zhujian7
Copy link
Member Author

/unhold

@openshift-merge-robot openshift-merge-robot merged commit 75db27d into open-cluster-management-io:main Sep 25, 2023
12 checks passed
TomerFi pushed a commit to TomerFi/OCM that referenced this pull request Sep 27, 2023
Signed-off-by: zhujian <jiazhu@redhat.com>

Signed-off-by: zhujian <jiazhu@redhat.com>
TomerFi pushed a commit to TomerFi/OCM that referenced this pull request Sep 27, 2023
Signed-off-by: ldpliu <daliu@redhat.com>

Signed-off-by: ldpliu <daliu@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants