🐛 fix failed update roleRef in clusterrolebinding in upgrade case #284
Conversation
|
/hold |
zhiweiyin318
force-pushed
the
fix-upgrade
branch
2 times, most recently
from
36fc1e3 to
f62bfaa
Compare
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #284 +/- ##
=======================================
Coverage 61.09% 61.09%
=======================================
Files 129 129
Lines 13752 13752
=======================================
Hits 8402 8402
+ Misses 4580 4579 -1
- Partials 770 771 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
zhiweiyin318
force-pushed
the
fix-upgrade
branch
from
f62bfaa to
dae174f
Compare
| @@ -38,7 +38,7 @@ var ( | |||
| "klusterlet/managed/klusterlet-work-clusterrole.yaml", | |||
| "klusterlet/managed/klusterlet-work-clusterrole-execution.yaml", | |||
| "klusterlet/managed/klusterlet-work-clusterrolebinding.yaml", | |||
| "klusterlet/managed/klusterlet-work-clusterrolebinding-execution.yaml", | |||
| "klusterlet/managed/klusterlet-work-clusterrolebinding-aggregate.yaml", | |||
There was a problem hiding this comment.
should we also add the old open-cluster-management:{{ .KlusterletName }}-work:execution in the list, otherwise, it can not be removed when deleting klusterlet?
There was a problem hiding this comment.
defined another cleanedManagedStaticResourceFiles to delete all manifests.
Signed-off-by: Zhiwei Yin <zyin@redhat.com>
zhiweiyin318
force-pushed
the
fix-upgrade
branch
from
dae174f to
e536be6
Compare
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: qiujian16, zhiweiyin318 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/unhold |
openshift-merge-robot
merged commit 769272c
into
open-cluster-management-io:main
Signed-off-by: Jian Qiu <jqiu@redhat.com> Signed-off-by: Jian Qiu <jqiu@redhat.com>
Signed-off-by: ldpliu <daliu@redhat.com> Signed-off-by: ldpliu <daliu@redhat.com>
Summary
the roleRef is changed in work-execution clusterrolebinding, so failed to update the clusterrolebinding during upgrade scenario.
Related issue(s)
Fixes #