Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 upgrade addon rollout library #288

Conversation

haoqing0110
Copy link
Member

Summary

Related issue(s)

Fixes #

@haoqing0110 haoqing0110 changed the title [wip] upgrade addon rollout library [wip] 🌱 upgrade addon rollout library Oct 7, 2023
@codecov
Copy link

codecov bot commented Oct 7, 2023

Codecov Report

Attention: 9 lines in your changes are missing coverage. Please review.

Comparison is base (80d4daa) 61.10% compared to head (0d69e72) 61.06%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #288      +/-   ##
==========================================
- Coverage   61.10%   61.06%   -0.04%     
==========================================
  Files         129      129              
  Lines       13761    13771      +10     
==========================================
+ Hits         8408     8409       +1     
- Misses       4581     4587       +6     
- Partials      772      775       +3     
Flag Coverage Δ
unit 61.06% <76.92%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
pkg/addon/controllers/addonconfiguration/graph.go 82.78% <76.92%> (-2.77%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@haoqing0110 haoqing0110 force-pushed the br_update-addon-rollout branch 2 times, most recently from 29180c9 to 6cd4153 Compare October 8, 2023 06:01
Signed-off-by: haoqing0110 <qhao@redhat.com>
@haoqing0110 haoqing0110 changed the title [wip] 🌱 upgrade addon rollout library 🌱 upgrade addon rollout library Oct 9, 2023
@haoqing0110
Copy link
Member Author

/assign @qiujian16

@qiujian16
Copy link
Member

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm label Oct 9, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 9, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: haoqing0110, qiujian16

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Oct 9, 2023
@openshift-ci openshift-ci bot merged commit 495e4cb into open-cluster-management-io:main Oct 9, 2023
14 checks passed
@haoqing0110 haoqing0110 deleted the br_update-addon-rollout branch October 9, 2023 07:02
mprahl pushed a commit to mprahl/OCM that referenced this pull request Mar 14, 2024
…r-management-io#288)

Signed-off-by: Wei Liu <liuweixa@redhat.com>

Signed-off-by: Wei Liu <liuweixa@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants