Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Fix release image manifest error #289

Merged
merged 1 commit into from
Oct 8, 2023

Conversation

qiujian16
Copy link
Member

Summary

Related issue(s)

Fixes #

@openshift-ci openshift-ci bot requested review from deads2k and jnpacker October 8, 2023 01:51
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 8, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qiujian16

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Oct 8, 2023
@qiujian16
Copy link
Member Author

/assign @zhujian7

@codecov
Copy link

codecov bot commented Oct 8, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (80d4daa) 61.10% compared to head (b37b820) 61.07%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #289      +/-   ##
==========================================
- Coverage   61.10%   61.07%   -0.03%     
==========================================
  Files         129      129              
  Lines       13761    13761              
==========================================
- Hits         8408     8405       -3     
- Misses       4581     4584       +3     
  Partials      772      772              
Flag Coverage Δ
unit 61.07% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Jian Qiu <jqiu@redhat.com>
@zhujian7
Copy link
Member

zhujian7 commented Oct 8, 2023

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Oct 8, 2023
@openshift-ci openshift-ci bot merged commit b88a0e9 into open-cluster-management-io:main Oct 8, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants