🌱 add metrics for placement #297
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haoqing0110
changed the title
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #297 +/- ##
==========================================
+ Coverage 61.39% 61.47% +0.07%
==========================================
Files 131 132 +1
Lines 13782 13844 +62
==========================================
+ Hits 8461 8510 +49
- Misses 4560 4570 +10
- Partials 761 764 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
|
/assign @qiujian16 @elgnay plz help review the sample metrics and code, will add more testing code. |
haoqing0110
force-pushed
the
br_placement-metrics
branch
3 times, most recently
from
7571c9f
to
0315ab3
Compare
haoqing0110
changed the title
haoqing0110
force-pushed
the
br_placement-metrics
branch
from
0315ab3
to
0373ff4
Compare
Signed-off-by: haoqing0110 <qhao@redhat.com>
haoqing0110
force-pushed
the
br_placement-metrics
branch
from
0373ff4
to
daf7aa1
Compare
qiujian16
reviewed
Oct 25, 2023
| @@ -46,6 +49,13 @@ func (s *Steady) Description() string { | |||
|
|
|||
| func (s *Steady) Score( | |||
| ctx context.Context, placement *clusterapiv1beta1.Placement, clusters []*clusterapiv1.ManagedCluster) (plugins.PluginScoreResult, *framework.Status) { | |||
| startTime := time.Now() | |||
There was a problem hiding this comment.
if this is the common thing, could we move this to the scheduler?
There was a problem hiding this comment.
yes, moved to scheduler.
Signed-off-by: haoqing0110 <qhao@redhat.com>
haoqing0110
force-pushed
the
br_placement-metrics
branch
3 times, most recently
from
17fe6c8
to
64bfc2b
Compare
Signed-off-by: haoqing0110 <qhao@redhat.com>
haoqing0110
force-pushed
the
br_placement-metrics
branch
from
64bfc2b
to
ed9ed5e
Compare
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: haoqing0110, qiujian16 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
merged commit 2f4ff9f
into
open-cluster-management-io:main
13 checks passed
mprahl
pushed a commit
to mprahl/OCM
that referenced
this pull request
Mar 14, 2024
) * use crd manager to update clean crds Signed-off-by: Jian Qiu <jqiu@redhat.com> * Update tests Signed-off-by: Jian Qiu <jqiu@redhat.com> * Rebase crd manager Signed-off-by: Jian Qiu <jqiu@redhat.com> * build client builder to make code clearer Signed-off-by: Jian Qiu <jqiu@redhat.com> * Add ut for crdmanager Signed-off-by: Jian Qiu <jqiu@redhat.com> * Compare crd spec when update Signed-off-by: Jian Qiu <jqiu@redhat.com> Signed-off-by: Jian Qiu <jqiu@redhat.com>
mprahl
pushed a commit
to mprahl/OCM
that referenced
this pull request
Mar 14, 2024
Signed-off-by: ldpliu <daliu@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Related issue(s)
Ref: open-cluster-management-io/placement#107
output