Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 upgrade addondeploymentconfigs to include proxy ca bundle #299

Merged

Conversation

elgnay
Copy link
Contributor

@elgnay elgnay commented Oct 27, 2023

Summary

Related issue(s)

Fixes #

Signed-off-by: Yang Le <yangle@redhat.com>
@openshift-ci openshift-ci bot requested review from deads2k and qiujian16 October 27, 2023 03:28
@codecov
Copy link

codecov bot commented Oct 27, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (2f4ff9f) 61.47% compared to head (7ceac6b) 61.47%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #299   +/-   ##
=======================================
  Coverage   61.47%   61.47%           
=======================================
  Files         132      132           
  Lines       13844    13844           
=======================================
  Hits         8510     8510           
  Misses       4570     4570           
  Partials      764      764           
Flag Coverage Δ
unit 61.47% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@elgnay elgnay closed this Oct 27, 2023
@elgnay elgnay reopened this Oct 27, 2023
@qiujian16
Copy link
Member

/approve
/lgtm

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 27, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: elgnay, qiujian16

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot merged commit 0f7da4a into open-cluster-management-io:main Oct 27, 2023
20 of 21 checks passed
elgnay added a commit to elgnay/ocm that referenced this pull request Oct 27, 2023
elgnay added a commit to elgnay/ocm that referenced this pull request Oct 27, 2023
elgnay added a commit to stolostron/ocm that referenced this pull request Oct 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants