🐛 should use hubClient instead of bootstrapClient for a creatingClusterController.

[xuezhaojun]

Summary

The controller resync every 1 min through the life-cycle of the registration-agent, but the bootstrapkubeconfig is expected to be a short-term thing.

Related issue(s)

Fixes #

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: xuezhaojun
Once this PR has been reviewed and has the lgtm label, please assign elgnay for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• pkg/registration/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[codecov]

Codecov Report

Attention: 14 lines in your changes are missing coverage. Please review.

Comparison is base (9aaa132) 61.15% compared to head (aa1d42b) 61.42%.
Report is 4 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #301      +/-   ##
==========================================
+ Coverage   61.15%   61.42%   +0.26%     
==========================================
  Files         129      132       +3     
  Lines       13661    13855     +194     
==========================================
+ Hits         8354     8510     +156     
- Misses       4547     4582      +35     
- Partials      760      763       +3     

Flag	Coverage Δ
unit	61.42% <0.00%> (+0.26%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files	Coverage Δ
pkg/registration/spoke/spokeagent.go	15.00% <0.00%> (-0.45%)	⬇️

... and 10 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[xuezhaojun]

/assign @qiujian16

[qiujian16]

/assign @skeeey

I do not remember whether we want creating cluster using hub kubeconfig (I thought it was desired) and if it has the permission to do that.

[xuezhaojun]

/assign @skeeey

I do not remember whether we want creating cluster using hub kubeconfig (I thought it was desired) and if it has the permission to do that.

Double check the code:

ocm/pkg/registration/spoke/registration/creating_controller.go

Lines 58 to 62 in c4bfa08

	// ManagedCluster is only allowed created during bootstrap. After bootstrap secret expired, an unauthorized error will be got, output log at the debug level
	if err != nil && skipUnauthorizedError(err) == nil {
	klog.V(4).Infof("unable to get the managed cluster %q from hub: %v", c.clusterName, err)
	return nil
	}

It seems although the controller will live, it won't function after the bootstrap stage.

Then no need to using hubClient, PR close.