Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Support setting manifest work config by addon template #308

Conversation

zhujian7
Copy link
Member

@zhujian7 zhujian7 commented Nov 6, 2023

Summary

Related issue(s)

Fixes #

Signed-off-by: zhujian <jiazhu@redhat.com>
@zhujian7 zhujian7 force-pushed the manifestwork-config branch from 8ba0722 to 08ad86a Compare November 16, 2023 09:06
Copy link

codecov bot commented Nov 16, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (615f5a4) 61.61% compared to head (48fbc04) 61.76%.

Files Patch % Lines
pkg/addon/templateagent/template_agent.go 90.47% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #308      +/-   ##
==========================================
+ Coverage   61.61%   61.76%   +0.15%     
==========================================
  Files         132      132              
  Lines       13956    13983      +27     
==========================================
+ Hits         8599     8637      +38     
+ Misses       4591     4580      -11     
  Partials      766      766              
Flag Coverage Δ
unit 61.76% <94.87%> (+0.15%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zhujian7 zhujian7 force-pushed the manifestwork-config branch 5 times, most recently from 7df68c5 to c49c1e0 Compare November 20, 2023 10:23
Signed-off-by: zhujian <jiazhu@redhat.com>
@zhujian7 zhujian7 force-pushed the manifestwork-config branch from c49c1e0 to 48fbc04 Compare November 20, 2023 10:23
@zhujian7 zhujian7 changed the title WIP ✨ Support setting manifest work config by addon template ✨ Support setting manifest work config by addon template Nov 20, 2023
@zhujian7
Copy link
Member Author

/cc @qiujian16

@openshift-ci openshift-ci bot requested a review from qiujian16 November 20, 2023 13:21
Copy link
Member

@qiujian16 qiujian16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

Copy link
Contributor

openshift-ci bot commented Nov 20, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qiujian16, zhujian7

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 6571a8a into open-cluster-management-io:main Nov 20, 2023
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants