Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ operator sdk support arm64 #319

Merged

Conversation

haowells
Copy link
Contributor

Summary

operator-sdk support Mac M2 locally build

Related issue(s)

$ ./_output/tools/bin/operator-sdk
bash: ./_output/tools/bin/operator-sdk: cannot execute binary file: Exec format error

Fixes #

Signed-off-by: haolin <haowells@gmail.com>
@openshift-ci openshift-ci bot requested review from deads2k and qiujian16 November 27, 2023 02:56
@haowells
Copy link
Contributor Author

/assign @qiujian16 @haoqing0110

@haowells haowells changed the title operator sdk support arm64 ✨ operator sdk support arm64 Nov 27, 2023
@zhujian7
Copy link
Member

/cc @zhiweiyin318

@openshift-ci openshift-ci bot requested a review from zhiweiyin318 November 27, 2023 03:00
Copy link

codecov bot commented Nov 27, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ab87bfc) 61.78% compared to head (a022cb2) 61.78%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #319   +/-   ##
=======================================
  Coverage   61.78%   61.78%           
=======================================
  Files         132      132           
  Lines       13983    13983           
=======================================
  Hits         8640     8640           
  Misses       4578     4578           
  Partials      765      765           
Flag Coverage Δ
unit 61.78% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@haoqing0110
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Nov 27, 2023
@zhiweiyin318
Copy link
Member

/approve

@zhiweiyin318
Copy link
Member

need approve from @qiujian16

@qiujian16
Copy link
Member

/approve

Copy link
Contributor

openshift-ci bot commented Nov 27, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: haowells, qiujian16, zhiweiyin318

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit fd06d92 into open-cluster-management-io:main Nov 27, 2023
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants