Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ klusterlet spec mount /tmp to emptydir volume #322

Merged
merged 1 commit into from
Nov 29, 2023

Conversation

haowells
Copy link
Contributor

@haowells haowells commented Nov 28, 2023

Summary

In our internal enviroment, pod PSP add security context readOnlyRootFilesystem: true, this cause klusterlet container failed to start up due to this error
F1128 02:00:36.380318 1 cmd.go:161] mkdir /tmp/serving-cert-9
believe this

config.ServingInfo.CertFile = filepath.Join(temporaryCertDir, "tls.crt")
config.ServingInfo.KeyFile = filepath.Join(temporaryCertDir, "tls.key")
// nothing can trust this, so we don't really care about hostnames
servingCert, err := ca.MakeServerCert(sets.NewString("localhost"), 30)
if err != nil {
return nil, nil, err
}
if err := servingCert.WriteCertConfigFile(config.ServingInfo.CertFile, config.ServingInfo.KeyFile); err != nil {
return nil, nil, err
code try to write something into /tmp dir

Related issue(s)

Fixes #

Signed-off-by: haolin <haowells@gmail.com>
@openshift-ci openshift-ci bot requested review from deads2k and qiujian16 November 28, 2023 10:38
Copy link

codecov bot commented Nov 28, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (8a4c834) 61.76% compared to head (24cc1fb) 61.76%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #322   +/-   ##
=======================================
  Coverage   61.76%   61.76%           
=======================================
  Files         132      132           
  Lines       13989    13989           
=======================================
  Hits         8641     8641           
  Misses       4583     4583           
  Partials      765      765           
Flag Coverage Δ
unit 61.76% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@qiujian16
Copy link
Member

/approv

@elgnay PTAL

@elgnay
Copy link
Contributor

elgnay commented Nov 28, 2023

/lgtm

@qiujian16
Copy link
Member

/approve

Copy link
Contributor

openshift-ci bot commented Nov 29, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: haowells, qiujian16

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 4a1a890 into open-cluster-management-io:main Nov 29, 2023
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants