Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 update deployment securityContext #329

Conversation

zhiweiyin318
Copy link
Member

Summary

Related issue(s)

Fixes #

Copy link

codecov bot commented Dec 7, 2023

Codecov Report

Attention: 52 lines in your changes are missing coverage. Please review.

Comparison is base (f89d535) 61.75% compared to head (b6a7b88) 61.63%.
Report is 3 commits behind head on main.

Files Patch % Lines
pkg/registration/hub/lease/clocksynccontroller.go 42.85% 47 Missing and 5 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #329      +/-   ##
==========================================
- Coverage   61.75%   61.63%   -0.13%     
==========================================
  Files         132      133       +1     
  Lines       13992    14083      +91     
==========================================
+ Hits         8641     8680      +39     
- Misses       4585     4632      +47     
- Partials      766      771       +5     
Flag Coverage Δ
unit 61.63% <42.85%> (-0.13%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Zhiwei Yin <zyin@redhat.com>
@qiujian16
Copy link
Member

/approve
/lgtm

Copy link
Contributor

openshift-ci bot commented Dec 8, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qiujian16, zhiweiyin318

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Dec 8, 2023
@openshift-merge-bot openshift-merge-bot bot merged commit 2e07fda into open-cluster-management-io:main Dec 8, 2023
13 checks passed
@zhiweiyin318 zhiweiyin318 deleted the upgdate-deployment branch December 8, 2023 03:26
mprahl pushed a commit to mprahl/OCM that referenced this pull request Mar 14, 2024
Signed-off-by: Zhiwei Yin <zyin@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants