Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Requeue for rolling strategy in mwrs #337

Merged

Conversation

qiujian16
Copy link
Member

Summary

Related issue(s)

Fixes #

Copy link
Contributor

openshift-ci bot commented Jan 2, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qiujian16

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Jan 2, 2024
Copy link

codecov bot commented Jan 2, 2024

Codecov Report

Attention: 135 lines in your changes are missing coverage. Please review.

Comparison is base (f89d535) 61.75% compared to head (1271e8d) 61.51%.
Report is 7 commits behind head on main.

Files Patch % Lines
...ollers/migrationcontroller/migration_controller.go 49.18% 56 Missing and 6 partials ⚠️
pkg/registration/hub/lease/clocksynccontroller.go 42.85% 47 Missing and 5 partials ⚠️
...setcontroller/manifestworkreplicaset_controller.go 20.00% 8 Missing and 4 partials ⚠️
...troller/manifestworkreplicaset_deploy_reconcile.go 62.50% 5 Missing and 1 partial ⚠️
pkg/common/helpers/error.go 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #337      +/-   ##
==========================================
- Coverage   61.75%   61.51%   -0.25%     
==========================================
  Files         132      133       +1     
  Lines       13992    14148     +156     
==========================================
+ Hits         8641     8703      +62     
- Misses       4585     4679      +94     
  Partials      766      766              
Flag Coverage Δ
unit 61.51% <45.78%> (-0.25%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Jian Qiu <jqiu@redhat.com>
@qiujian16 qiujian16 force-pushed the rollout-requeue branch 2 times, most recently from c8327bb to 3db3539 Compare January 4, 2024 08:30
Signed-off-by: Jian Qiu <jqiu@redhat.com>
@haoqing0110
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Jan 4, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 976019d into open-cluster-management-io:main Jan 4, 2024
13 checks passed
mprahl pushed a commit to mprahl/OCM that referenced this pull request Mar 14, 2024
…ster-management-io#337)

* check managed cluster connectivity when deleting klusterlet

Signed-off-by: zhujian <jiazhu@redhat.com>

* check managed cluster connectivity just after building the clients

Signed-off-by: zhujian <jiazhu@redhat.com>

---------

Signed-off-by: zhujian <jiazhu@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants