Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 addon support rollout configs #340

Conversation

haoqing0110
Copy link
Member

@haoqing0110 haoqing0110 commented Jan 4, 2024

Summary

Ref #332

Related issue(s)

Fixes #

@haoqing0110
Copy link
Member Author

/hold

Copy link

codecov bot commented Jan 5, 2024

Codecov Report

Attention: 162 lines in your changes are missing coverage. Please review.

Comparison is base (f89d535) 61.75% compared to head (d34ad43) 61.46%.
Report is 8 commits behind head on main.

Files Patch % Lines
...ollers/migrationcontroller/migration_controller.go 49.18% 56 Missing and 6 partials ⚠️
pkg/registration/hub/lease/clocksynccontroller.go 42.85% 47 Missing and 5 partials ⚠️
...addon/controllers/addonconfiguration/controller.go 0.00% 15 Missing ⚠️
...setcontroller/manifestworkreplicaset_controller.go 20.00% 8 Missing and 4 partials ⚠️
...donconfiguration/addon_configuration_reconciler.go 14.28% 4 Missing and 2 partials ⚠️
pkg/addon/controllers/addonconfiguration/graph.go 78.57% 4 Missing and 2 partials ⚠️
...troller/manifestworkreplicaset_deploy_reconcile.go 62.50% 5 Missing and 1 partial ⚠️
pkg/common/helpers/error.go 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #340      +/-   ##
==========================================
- Coverage   61.75%   61.46%   -0.29%     
==========================================
  Files         132      133       +1     
  Lines       13992    14193     +201     
==========================================
+ Hits         8641     8724      +83     
- Misses       4585     4699     +114     
- Partials      766      770       +4     
Flag Coverage Δ
unit 61.46% <46.88%> (-0.29%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: haoqing0110 <qhao@redhat.com>
@haoqing0110
Copy link
Member Author

/assign @qiujian16

Copy link
Member

@qiujian16 qiujian16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

Copy link
Contributor

openshift-ci bot commented Jan 8, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: haoqing0110, qiujian16

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Jan 8, 2024
@haoqing0110
Copy link
Member Author

/unhold

@qiujian16
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Jan 8, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 40135fd into open-cluster-management-io:main Jan 8, 2024
13 checks passed
@haoqing0110 haoqing0110 deleted the br_addon-timeout branch September 3, 2024 01:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants