Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Remove codecov token. #345

Conversation

xuezhaojun
Copy link
Member

Summary

Recently, the codecov push keeps fail, through test we know the token is not required for public repos, so we can remove the token to fix that failure, the approach is verified in cluster-proxy-addon repo: open-cluster-management-io/cluster-proxy#174

Also the OCM_BOT_TOKEN also shows "Bad credentials" when we try to trigger clusteradmin e2e test after PR merged, can we have a check on that token in case it's out-of-date? @qiujian16

Related issue(s)

Fixes #

https://github.com/open-cluster-management-io/ocm/actions/runs/7497318242/job/20410721816

Signed-off-by: xuezhaojun <zxue@redhat.com>
@openshift-ci openshift-ci bot requested review from deads2k and qiujian16 January 17, 2024 05:47
Copy link

codecov bot commented Jan 17, 2024

Codecov Report

Attention: 154 lines in your changes are missing coverage. Please review.

Comparison is base (f89d535) 61.75% compared to head (037bc4a) 61.52%.
Report is 14 commits behind head on main.

Files Patch % Lines
...ollers/migrationcontroller/migration_controller.go 56.09% 50 Missing and 4 partials ⚠️
pkg/registration/hub/lease/clocksynccontroller.go 42.85% 47 Missing and 5 partials ⚠️
...addon/controllers/addonconfiguration/controller.go 0.00% 15 Missing ⚠️
...setcontroller/manifestworkreplicaset_controller.go 20.00% 8 Missing and 4 partials ⚠️
...donconfiguration/addon_configuration_reconciler.go 14.28% 4 Missing and 2 partials ⚠️
pkg/addon/controllers/addonconfiguration/graph.go 78.57% 4 Missing and 2 partials ⚠️
...troller/manifestworkreplicaset_deploy_reconcile.go 62.50% 5 Missing and 1 partial ⚠️
pkg/common/helpers/error.go 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #345      +/-   ##
==========================================
- Coverage   61.75%   61.52%   -0.24%     
==========================================
  Files         132      133       +1     
  Lines       13992    14189     +197     
==========================================
+ Hits         8641     8730      +89     
- Misses       4585     4691     +106     
- Partials      766      768       +2     
Flag Coverage Δ
unit 61.52% <49.67%> (-0.24%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@xuezhaojun
Copy link
Member Author

/assign @qiujian16

No code change, just remove the codecov token to avoid bad cridetials issue now and in the future.

@qiujian16
Copy link
Member

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm label Jan 18, 2024
Copy link
Contributor

openshift-ci bot commented Jan 18, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qiujian16, xuezhaojun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 66b7890 into open-cluster-management-io:main Jan 18, 2024
13 checks passed
@xuezhaojun xuezhaojun deleted the remove-codecov-token branch January 18, 2024 03:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants