Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 Switch to sdk-go for helper functions #346

Merged

Conversation

qiujian16
Copy link
Member

Summary

Related issue(s)

Fixes #

@openshift-ci openshift-ci bot requested review from elgnay and haoqing0110 January 17, 2024 09:04
Copy link
Contributor

openshift-ci bot commented Jan 17, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qiujian16

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Signed-off-by: Jian Qiu <jqiu@redhat.com>
Copy link

codecov bot commented Jan 17, 2024

Codecov Report

Attention: 160 lines in your changes are missing coverage. Please review.

Comparison is base (f89d535) 61.75% compared to head (eb430ba) 61.54%.
Report is 11 commits behind head on main.

Files Patch % Lines
...ollers/migrationcontroller/migration_controller.go 56.09% 50 Missing and 4 partials ⚠️
pkg/registration/hub/lease/clocksynccontroller.go 42.85% 47 Missing and 5 partials ⚠️
...addon/controllers/addonconfiguration/controller.go 0.00% 15 Missing ⚠️
...setcontroller/manifestworkreplicaset_controller.go 20.00% 8 Missing and 4 partials ⚠️
pkg/addon/controllers/addonconfiguration/graph.go 84.09% 5 Missing and 2 partials ⚠️
...troller/manifestworkreplicaset_deploy_reconcile.go 73.07% 6 Missing and 1 partial ⚠️
...donconfiguration/addon_configuration_reconciler.go 14.28% 4 Missing and 2 partials ⚠️
pkg/common/helpers/error.go 0.00% 3 Missing ⚠️
pkg/work/helper/helpers.go 0.00% 2 Missing ⚠️
...g/registration/hub/managedclusterset/controller.go 75.00% 1 Missing ⚠️
... and 1 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #346      +/-   ##
==========================================
- Coverage   61.75%   61.54%   -0.22%     
==========================================
  Files         132      133       +1     
  Lines       13992    14185     +193     
==========================================
+ Hits         8641     8730      +89     
- Misses       4585     4687     +102     
- Partials      766      768       +2     
Flag Coverage Δ
unit 61.54% <53.07%> (-0.22%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@haoqing0110
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Jan 17, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 1d42f42 into open-cluster-management-io:main Jan 17, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants