Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Check the template type addon status immediately when the cluster status changes #350

Merged

Conversation

zhujian7
Copy link
Member

Summary

Related issue(s)

Fixes #

Copy link

codecov bot commented Jan 19, 2024

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (01521e3) 61.57% compared to head (156209a) 61.54%.

Files Patch % Lines
pkg/addon/templateagent/template_agent.go 0.00% 4 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #350      +/-   ##
==========================================
- Coverage   61.57%   61.54%   -0.03%     
==========================================
  Files         133      133              
  Lines       14198    14200       +2     
==========================================
- Hits         8743     8740       -3     
- Misses       4688     4692       +4     
- Partials      767      768       +1     
Flag Coverage Δ
unit 61.54% <0.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zhujian7 zhujian7 changed the title 🐛 Check the template type addon status imediately when the cluster status changes 🐛 Check the template type addon status immediately when the cluster status changes Jan 19, 2024
…tus changes

Signed-off-by: zhujian <jiazhu@redhat.com>
@zhujian7
Copy link
Member Author

/cc @elgnay @qiujian16

Copy link
Member

@qiujian16 qiujian16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

Copy link
Contributor

openshift-ci bot commented Jan 22, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qiujian16, zhujian7

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 5d99f4b into open-cluster-management-io:main Jan 22, 2024
13 checks passed
mprahl pushed a commit to mprahl/OCM that referenced this pull request Mar 14, 2024
Signed-off-by: Zhiwei Yin <zyin@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants