Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 Bump api and addon-framework deps #354

Conversation

qiujian16
Copy link
Member

Summary

Related issue(s)

Fixes #

Signed-off-by: Jian Qiu <jqiu@redhat.com>
@openshift-ci openshift-ci bot requested review from elgnay and haoqing0110 January 23, 2024 06:33
Copy link
Contributor

openshift-ci bot commented Jan 23, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qiujian16

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@zhiweiyin318
Copy link
Member

/lgtm

@zhujian7
Copy link
Member

/lgtm

Copy link

codecov bot commented Jan 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (bede3ed) 61.10% compared to head (e6dedf1) 61.35%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #354      +/-   ##
==========================================
+ Coverage   61.10%   61.35%   +0.24%     
==========================================
  Files         130      132       +2     
  Lines       13857    13996     +139     
==========================================
+ Hits         8468     8587     +119     
- Misses       4640     4657      +17     
- Partials      749      752       +3     
Flag Coverage Δ
unit 61.35% <100.00%> (+0.24%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@openshift-merge-bot openshift-merge-bot bot merged commit c04ab36 into open-cluster-management-io:main Jan 23, 2024
13 checks passed
@qiujian16 qiujian16 deleted the update-addon-deps branch January 23, 2024 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants