Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ support configuration of the agent priorityclass #358

Conversation

elgnay
Copy link
Contributor

@elgnay elgnay commented Feb 2, 2024

Summary

Related issue(s)

Fixes #

@elgnay
Copy link
Contributor Author

elgnay commented Feb 2, 2024

/hold

Copy link

codecov bot commented Feb 2, 2024

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (68a6c1f) 61.29% compared to head (baeff5d) 61.30%.

Files Patch % Lines
pkg/operator/helpers/helpers.go 63.63% 2 Missing and 2 partials ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #358   +/-   ##
=======================================
  Coverage   61.29%   61.30%           
=======================================
  Files         132      132           
  Lines       14020    14032   +12     
=======================================
+ Hits         8594     8602    +8     
- Misses       4672     4674    +2     
- Partials      754      756    +2     
Flag Coverage Δ
unit 61.30% <66.66%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Yang Le <yangle@redhat.com>
@elgnay elgnay force-pushed the agent-priority-class branch from 6cb8a72 to baeff5d Compare February 6, 2024 07:39
Copy link
Member

@qiujian16 qiujian16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

Copy link
Contributor

openshift-ci bot commented Feb 6, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: elgnay, qiujian16

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Feb 6, 2024
@elgnay
Copy link
Contributor Author

elgnay commented Feb 8, 2024

/unhold

@openshift-merge-bot openshift-merge-bot bot merged commit c5e210a into open-cluster-management-io:main Feb 8, 2024
13 checks passed
elgnay added a commit to elgnay/ocm that referenced this pull request Feb 8, 2024
openshift-merge-bot bot pushed a commit to stolostron/ocm that referenced this pull request Feb 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants