✨ Add a flag for work agent to set raw json length #366
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: qiujian16 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
skeeey
reviewed
Mar 6, 2024
| if len(jsonRaw) > maxJsonRawLength { | ||
| return nil, fmt.Errorf("the length of returned json raw string for name %s is larger than the maximum length %d", name, maxJsonRawLength) | ||
| if len(jsonRaw) > int(s.maxJSONRawLength) { | ||
| return nil, fmt.Errorf("the length of returned json raw string for name %s is larger than the maximum length %d", name, maxJSONRawLength) |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #366 +/- ##
==========================================
+ Coverage 61.30% 61.33% +0.03%
==========================================
Files 132 132
Lines 14032 14036 +4
==========================================
+ Hits 8602 8609 +7
+ Misses 4674 4672 -2
+ Partials 756 755 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Jian Qiu <jqiu@redhat.com>
qiujian16
force-pushed
the
raw-json-length
branch
from
2a00b2d to
33c5808
Compare
|
LGTM |
|
/lgtm |
openshift-merge-bot
bot
merged commit 92d4f86
into
open-cluster-management-io:main
14 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Related issue(s)
Fixes #