🐛 update the addon-framework and getSpechHash algorithm #371
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #371 +/- ##
==========================================
- Coverage 61.37% 61.35% -0.03%
==========================================
Files 132 132
Lines 14051 14051
==========================================
- Hits 8624 8621 -3
- Misses 4672 4674 +2
- Partials 755 756 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
go.mod
Outdated
| open-cluster-management.io/api v0.13.0 | ||
| open-cluster-management.io/sdk-go v0.13.1-0.20240306030534-3142983462d9 | ||
| sigs.k8s.io/controller-runtime v0.16.2 | ||
| sigs.k8s.io/controller-runtime v0.17.0 |
There was a problem hiding this comment.
Please use sigs.k8s.io/controller-runtime v0.17.2 . The Restmapper is buggy before that.
haoqing0110
force-pushed
the
br_update-getspechash
branch
from
ca171ea to
6a50beb
Compare
Signed-off-by: haoqing0110 <qhao@redhat.com>
haoqing0110
force-pushed
the
br_update-getspechash
branch
from
6a50beb to
813f506
Compare
|
/assign @qiujian16 |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: haoqing0110, qiujian16 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit b4bf3d0
into
open-cluster-management-io:main
…anagement-io#371) Signed-off-by: haoqing0110 <qhao@redhat.com>
Summary
Related issue(s)
open-cluster-management-io/addon-framework#243
#364
open-cluster-management-io/addon-framework#237
Fixes #