✨ Retrigger CSR when certs doesn't has desired org and ou of subject(registrationConfig). #377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #377 +/- ##
==========================================
+ Coverage 61.37% 61.41% +0.03%
==========================================
Files 132 132
Lines 14051 14064 +13
==========================================
+ Hits 8624 8637 +13
- Misses 4672 4673 +1
+ Partials 755 754 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
/assign @qiujian16 |
qiujian16
reviewed
Mar 13, 2024
| } | ||
|
|
||
| // check groups(origanization) | ||
| if len(subject.Organization) > 0 { |
xuezhaojun
force-pushed
the
trigger-csr-when-subject-groups-or-ou-change
branch
2 times, most recently
from
3016c19 to
d644f18
Compare
Signed-off-by: GitHub <noreply@github.com>
xuezhaojun
force-pushed
the
trigger-csr-when-subject-groups-or-ou-change
branch
from
4041177 to
fcace39
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: qiujian16, xuezhaojun The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit edef33d
into
open-cluster-management-io:main
13 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Before: the CSR only be retriggerred when subject.CommonName doesn't match.
Now: if there is no certs match subject (commonnam + org + ou) , CSR get retriggered.