Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 upgrade addon-framework #383

Conversation

haoqing0110
Copy link
Member

@haoqing0110 haoqing0110 commented Mar 25, 2024

Summary

Ref: #355

Related issue(s)

Fixes #

@openshift-ci openshift-ci bot requested review from zhiweiyin318 and zhujian7 March 25, 2024 08:41
@haoqing0110
Copy link
Member Author

/hold

Copy link

codecov bot commented Mar 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.48%. Comparing base (22501d8) to head (06da451).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #383      +/-   ##
==========================================
- Coverage   61.48%   61.48%   -0.01%     
==========================================
  Files         133      133              
  Lines       14087    14086       -1     
==========================================
- Hits         8662     8661       -1     
  Misses       4672     4672              
  Partials      753      753              
Flag Coverage Δ
unit 61.48% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@haoqing0110 haoqing0110 force-pushed the br_update-addon-framework branch 2 times, most recently from 4d0dca0 to da09b00 Compare March 27, 2024 03:24
@haoqing0110
Copy link
Member Author

/unhold

Signed-off-by: haoqing0110 <qhao@redhat.com>
@haoqing0110 haoqing0110 force-pushed the br_update-addon-framework branch from da09b00 to 06da451 Compare March 27, 2024 07:18
@haoqing0110
Copy link
Member Author

/assign @qiujian16 @zhujian7

@qiujian16
Copy link
Member

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm label Mar 28, 2024
Copy link
Contributor

openshift-ci bot commented Mar 28, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: haoqing0110, qiujian16

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit ff77abd into open-cluster-management-io:main Mar 28, 2024
14 checks passed
@haoqing0110 haoqing0110 deleted the br_update-addon-framework branch March 28, 2024 06:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants