🐛 CI should pass when on codecov upload fail. #396
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xuezhaojun
force-pushed
the
retry-on-codecov
branch
from
06329a8
to
2a5cf3a
Compare
xuezhaojun
changed the title
Signed-off-by: GitHub <noreply@github.com>
xuezhaojun
force-pushed
the
retry-on-codecov
branch
from
2a5cf3a
to
1338cd9
Compare
xuezhaojun
changed the title
xuezhaojun
changed the title
|
/assign @qiujian16 |
zhujian7
reviewed
Apr 8, 2024
| @@ -69,7 +69,7 @@ jobs: | |||
| flags: unit | |||
| name: unit | |||
| verbose: true | |||
| fail_ci_if_error: true | |||
| fail_ci_if_error: false | |||
There was a problem hiding this comment.
add a TODO like change this back when we find a way to stabilize it?
There was a problem hiding this comment.
That's a good point to discuss on, I prefer leave it be to false. And if codecov continously being unstable we transfer to another tool.
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: qiujian16, xuezhaojun The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit 603a92c
into
open-cluster-management-io:main
15 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Codecov becomes because github api outage sometimes. Change to pass CI job when the codecov upload is failed.
Related issue(s)
codecov/codecov-action#926