Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 add admissionregistration group to work execution clusterrole #401

Conversation

zhiweiyin318
Copy link
Member

Summary

add permission to make work support to apply mutatingwebhookconfigurations and validatingwebhookconfigurations resouces.

Related issue(s)

#384
Fixes #

@openshift-ci openshift-ci bot requested review from jnpacker and qiujian16 April 8, 2024 06:41
Signed-off-by: Zhiwei Yin <zyin@redhat.com>
@zhiweiyin318
Copy link
Member Author

/assign @qiujian16

@qiujian16
Copy link
Member

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm label Apr 8, 2024
Copy link
Contributor

openshift-ci bot commented Apr 8, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qiujian16, zhiweiyin318

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Apr 8, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 3efb7d3 into open-cluster-management-io:main Apr 8, 2024
12 checks passed
@mikeshng
Copy link
Member

/cherrypick release-0.13

@openshift-cherrypick-robot

@mikeshng: new pull request created: #420

In response to this:

/cherry-pick release-0.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot

@mikeshng: new pull request could not be created: failed to create pull request against open-cluster-management-io/ocm#release-0.13 from head openshift-cherrypick-robot:cherry-pick-401-to-release-0.13: status code 422 not one of [201], body: {"message":"Validation Failed","errors":[{"resource":"PullRequest","code":"custom","message":"A pull request already exists for openshift-cherrypick-robot:cherry-pick-401-to-release-0.13."}],"documentation_url":"https://docs.github.com/rest/pulls/pulls#create-a-pull-request"}

In response to this:

/cherrypick release-0.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@zhiweiyin318 zhiweiyin318 deleted the add-permission branch April 15, 2024 02:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants