Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 refactor constants in operator #421

Conversation

zhiweiyin318
Copy link
Member

Summary

Related issue(s)

Fixes #

@openshift-ci openshift-ci bot requested review from xuezhaojun and zhujian7 April 12, 2024 02:38
@zhiweiyin318 zhiweiyin318 force-pushed the refactor-constants branch 2 times, most recently from 4d333d5 to 41f2e43 Compare April 12, 2024 14:59
Copy link

codecov bot commented Apr 12, 2024

Codecov Report

Attention: Patch coverage is 58.42697% with 37 lines in your changes are missing coverage. Please review.

Project coverage is 62.43%. Comparing base (bcbe4d2) to head (921602b).
Report is 15 commits behind head on main.

Files Patch % Lines
pkg/operator/helpers/helpers.go 0.00% 6 Missing ⚠️
...ollers/migrationcontroller/migration_controller.go 61.53% 4 Missing and 1 partial ⚠️
...agercontroller/clustermanager_runtime_reconcile.go 50.00% 4 Missing ⚠️
...usterletcontroller/klusterlet_runtime_reconcile.go 20.00% 3 Missing and 1 partial ⚠️
...s/statuscontroller/klusterlet_status_controller.go 66.66% 3 Missing and 1 partial ⚠️
...llers/ssarcontroller/klusterlet_ssar_controller.go 70.00% 3 Missing ⚠️
...rmanagercontroller/clustermanager_crd_reconcile.go 0.00% 2 Missing ⚠️
...agercontroller/clustermanager_webhook_reconcile.go 33.33% 2 Missing ⚠️
...lers/klusterletcontroller/klusterlet_controller.go 71.42% 2 Missing ⚠️
...rmanagercontroller/clustermanager_hub_reconcile.go 0.00% 1 Missing ⚠️
... and 4 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #421      +/-   ##
==========================================
+ Coverage   61.54%   62.43%   +0.88%     
==========================================
  Files         133      133              
  Lines       14078    11313    -2765     
==========================================
- Hits         8665     7063    -1602     
+ Misses       4664     3501    -1163     
  Partials      749      749              
Flag Coverage Δ
unit 62.43% <58.42%> (+0.88%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zhiweiyin318 zhiweiyin318 force-pushed the refactor-constants branch 4 times, most recently from 5aac64a to 87496f2 Compare April 13, 2024 02:22
@zhujian7
Copy link
Member

lgtm

@qiujian16
Copy link
Member

/approve
/lgtm

Copy link
Contributor

openshift-ci bot commented Apr 15, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qiujian16, zhiweiyin318

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Signed-off-by: Zhiwei Yin <zyin@redhat.com>
@zhujian7
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Apr 15, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit f413220 into open-cluster-management-io:main Apr 15, 2024
14 checks passed
@zhiweiyin318 zhiweiyin318 deleted the refactor-constants branch April 15, 2024 05:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants