-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 Get default registration namespace from template manifest #427
🐛 Get default registration namespace from template manifest #427
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: qiujian16 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
a0eb48c
to
cc8013d
Compare
cc8013d
to
9a0e661
Compare
} | ||
|
||
// pick the namespace of the first deployment | ||
var desiredNS = "open-cluster-management-agent-addon" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we have the const "open-cluster-management-agent-addon" in the api repo?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sadly no...
9a0e661
to
3b7792c
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #427 +/- ##
==========================================
+ Coverage 61.54% 62.40% +0.85%
==========================================
Files 133 133
Lines 14078 11333 -2745
==========================================
- Hits 8665 7072 -1593
+ Misses 4664 3507 -1157
- Partials 749 754 +5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
4bbd743
to
3152bcc
Compare
Signed-off-by: Jian Qiu <jqiu@redhat.com>
3152bcc
to
c41cb61
Compare
/lgtm |
/hold |
37693a4
into
open-cluster-management-io:main
/unhold |
Summary
Related issue(s)
Fixes #426