Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Get default registration namespace from template manifest #427

Merged

Conversation

qiujian16
Copy link
Member

@qiujian16 qiujian16 commented Apr 16, 2024

Summary

Related issue(s)

Fixes #426

@openshift-ci openshift-ci bot requested review from haoqing0110 and zhujian7 April 16, 2024 07:03
Copy link
Contributor

openshift-ci bot commented Apr 16, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qiujian16

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@qiujian16 qiujian16 changed the title 🐛 Get default registration namespace from template manifest 🐛 [WIP] Get default registration namespace from template manifest Apr 16, 2024
}

// pick the namespace of the first deployment
var desiredNS = "open-cluster-management-agent-addon"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we have the const "open-cluster-management-agent-addon" in the api repo?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sadly no...

Copy link

codecov bot commented Apr 16, 2024

Codecov Report

Attention: Patch coverage is 65.38462% with 9 lines in your changes are missing coverage. Please review.

Project coverage is 62.40%. Comparing base (bcbe4d2) to head (3152bcc).
Report is 19 commits behind head on main.

❗ Current head 3152bcc differs from pull request most recent head c41cb61. Consider uploading reports for the commit c41cb61 to get more accurate results

Files Patch % Lines
pkg/addon/templateagent/template_agent.go 65.38% 5 Missing and 4 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #427      +/-   ##
==========================================
+ Coverage   61.54%   62.40%   +0.85%     
==========================================
  Files         133      133              
  Lines       14078    11333    -2745     
==========================================
- Hits         8665     7072    -1593     
+ Misses       4664     3507    -1157     
- Partials      749      754       +5     
Flag Coverage Δ
unit 62.40% <65.38%> (+0.85%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@qiujian16 qiujian16 force-pushed the registration-ns branch 3 times, most recently from 4bbd743 to 3152bcc Compare April 17, 2024 07:24
Signed-off-by: Jian Qiu <jqiu@redhat.com>
@qiujian16 qiujian16 changed the title 🐛 [WIP] Get default registration namespace from template manifest 🐛 Get default registration namespace from template manifest Apr 17, 2024
@zhujian7
Copy link
Member

/lgtm

@zhujian7
Copy link
Member

/hold

@openshift-merge-bot openshift-merge-bot bot merged commit 37693a4 into open-cluster-management-io:main Apr 17, 2024
14 checks passed
@zhujian7
Copy link
Member

/unhold

@qiujian16 qiujian16 deleted the registration-ns branch April 17, 2024 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The addon registration namespace is not correctly set for addonTemplate
3 participants