Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Add default values for workloadsourcedriver and worksourceloadconfig. #432

Conversation

xuezhaojun
Copy link
Member

Summary

Related issue(s)

Fixes #

@openshift-ci openshift-ci bot requested review from zhiweiyin318 and zhujian7 April 19, 2024 03:25
Signed-off-by: GitHub <noreply@github.com>
@xuezhaojun
Copy link
Member Author

/assign @qiujian16

Copy link

codecov bot commented Apr 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 62.41%. Comparing base (bcbe4d2) to head (4dc1472).
Report is 22 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #432      +/-   ##
==========================================
+ Coverage   61.54%   62.41%   +0.86%     
==========================================
  Files         133      133              
  Lines       14078    11333    -2745     
==========================================
- Hits         8665     7074    -1591     
+ Misses       4664     3506    -1158     
- Partials      749      753       +4     
Flag Coverage Δ
unit 62.41% <ø> (+0.86%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@qiujian16
Copy link
Member

/approve

verify failed

@xuezhaojun xuezhaojun force-pushed the fix-add-default-value-for-workloadsource branch from 581261a to 4dc1472 Compare April 20, 2024 12:55
@xuezhaojun
Copy link
Member Author

xuezhaojun commented Apr 20, 2024

/approve

verify failed

@qiujian16 Updated, please take another look.

And maybe we need to rethink the value this the force import sequence check brings, whether do we need to keep it or not.

@xuezhaojun xuezhaojun closed this Apr 20, 2024
@xuezhaojun xuezhaojun reopened this Apr 20, 2024
@xuezhaojun xuezhaojun closed this Apr 20, 2024
@xuezhaojun xuezhaojun reopened this Apr 20, 2024
@qiujian16
Copy link
Member

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm label Apr 22, 2024
Copy link
Contributor

openshift-ci bot commented Apr 22, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qiujian16, xuezhaojun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit dee7f10 into open-cluster-management-io:main Apr 22, 2024
35 of 37 checks passed
@xuezhaojun xuezhaojun deleted the fix-add-default-value-for-workloadsource branch April 22, 2024 01:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants