Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Add codecov token back. #444

Conversation

xuezhaojun
Copy link
Member

Summary

codecov-action doesn't support tokenless upload since v4: codecov/codecov-action#1292

Signed-off-by: GitHub <noreply@github.com>
@xuezhaojun
Copy link
Member Author

/assign @qiujian16

Copy link

codecov bot commented Apr 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 62.53%. Comparing base (bcbe4d2) to head (b8fcd63).
Report is 31 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #444      +/-   ##
==========================================
+ Coverage   61.54%   62.53%   +0.98%     
==========================================
  Files         133      134       +1     
  Lines       14078    11430    -2648     
==========================================
- Hits         8665     7148    -1517     
+ Misses       4664     3520    -1144     
- Partials      749      762      +13     
Flag Coverage Δ
unit 62.53% <ø> (+0.98%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@xuezhaojun xuezhaojun closed this Apr 26, 2024
@xuezhaojun xuezhaojun reopened this Apr 26, 2024
@qiujian16
Copy link
Member

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm label Apr 26, 2024
Copy link
Contributor

openshift-ci bot commented Apr 26, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qiujian16, xuezhaojun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 799ee4f into open-cluster-management-io:main Apr 26, 2024
23 of 24 checks passed
@xuezhaojun xuezhaojun deleted the add-codecov-token-back branch August 16, 2024 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants