Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 honor the settings of AppliedManifestWorkEvictionGracePeriod in Klu… #454

Merged

Conversation

elgnay
Copy link
Contributor

@elgnay elgnay commented May 9, 2024

…sterlet API

Summary

Related issue(s)

Fixes #

@openshift-ci openshift-ci bot requested review from zhiweiyin318 and zhujian7 May 9, 2024 10:24
@elgnay
Copy link
Contributor Author

elgnay commented May 9, 2024

/hold

Copy link

codecov bot commented May 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 62.64%. Comparing base (c749b42) to head (364155d).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #454      +/-   ##
==========================================
+ Coverage   62.56%   62.64%   +0.07%     
==========================================
  Files         136      136              
  Lines       11504    11515      +11     
==========================================
+ Hits         7198     7213      +15     
+ Misses       3537     3535       -2     
+ Partials      769      767       -2     
Flag Coverage Δ
unit 62.64% <100.00%> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@elgnay elgnay force-pushed the eviction-settings branch from d7ca4a0 to fa4739f Compare May 10, 2024 07:28
…sterlet API

Signed-off-by: Yang Le <yangle@redhat.com>
@elgnay elgnay force-pushed the eviction-settings branch from fa4739f to 364155d Compare May 10, 2024 08:21
@zhujian7
Copy link
Member

/lgtm

Copy link
Member

@qiujian16 qiujian16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

Copy link
Contributor

openshift-ci bot commented May 13, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: elgnay, qiujian16

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@elgnay
Copy link
Contributor Author

elgnay commented May 13, 2024

/hold cancel

@openshift-merge-bot openshift-merge-bot bot merged commit 4e29181 into open-cluster-management-io:main May 13, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants