Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 should not stop other reconcilers when failed to sync images #456

Conversation

zhiweiyin318
Copy link
Member

Summary

should not stop other reconcilers when failed to sync images.

Related issue(s)

Fixes #

Signed-off-by: Zhiwei Yin <zyin@redhat.com>
@openshift-ci openshift-ci bot requested review from xuezhaojun and zhujian7 May 11, 2024 09:34
@zhiweiyin318 zhiweiyin318 changed the title 🐛 failed sync image stop other reconciler 🐛 should not stop other reconcilers when failed to sync images May 11, 2024
Copy link

codecov bot commented May 11, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 62.58%. Comparing base (f44670d) to head (278aee6).

Files Patch % Lines
...nagercontroller/clustermanager_secret_reconcile.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #456   +/-   ##
=======================================
  Coverage   62.58%   62.58%           
=======================================
  Files         136      136           
  Lines       11504    11504           
=======================================
  Hits         7200     7200           
  Misses       3536     3536           
  Partials      768      768           
Flag Coverage Δ
unit 62.58% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zhiweiyin318
Copy link
Member Author

/assign @qiujian16

@qiujian16
Copy link
Member

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm label May 13, 2024
Copy link
Contributor

openshift-ci bot commented May 13, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qiujian16, zhiweiyin318

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit e4202dd into open-cluster-management-io:main May 13, 2024
15 checks passed
@zhiweiyin318 zhiweiyin318 deleted the fix-pullimage branch May 13, 2024 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants