Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ upgrade sdk to support Kafka as a cloudevents driver #460

Merged
merged 2 commits into from
May 14, 2024

Conversation

clyang82
Copy link
Contributor

@clyang82 clyang82 commented May 13, 2024

Summary

Upgrade sdd-go to support new feature. for instance, kafka as a cloudevents driver.
By default, we won't build kafka. it can be enabled when passing -tags=kafka during build stage.

Related issue(s)

#436

Fixes #

GOARCH=arm64 go build  ./cmd/registration
go build  ./cmd/registration

the above command can be executed successfully. that means the cross-compilation won't be broken.

Signed-off-by: clyang82 <chuyang@redhat.com>
@openshift-ci openshift-ci bot requested review from elgnay and ldpliu May 13, 2024 14:56
Signed-off-by: clyang82 <chuyang@redhat.com>
Copy link

codecov bot commented May 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 62.64%. Comparing base (d7c4526) to head (b1abf11).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #460   +/-   ##
=======================================
  Coverage   62.64%   62.64%           
=======================================
  Files         136      136           
  Lines       11515    11515           
=======================================
  Hits         7213     7213           
  Misses       3535     3535           
  Partials      767      767           
Flag Coverage Δ
unit 62.64% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@qiujian16
Copy link
Member

/approve
/lgtm

Copy link
Contributor

openshift-ci bot commented May 14, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: clyang82, qiujian16

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 4117a4b into open-cluster-management-io:main May 14, 2024
15 checks passed
@clyang82 clyang82 deleted the kafka branch May 14, 2024 02:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants