Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ configurable controller replicas and master node selector #468

Conversation

dongbeiqing91
Copy link
Contributor

@dongbeiqing91 dongbeiqing91 commented May 20, 2024

Summary

In production, operators should be able to controll the replicas of the deployments. Making replicas larger than 1 is very important. So this PR is submitted to make deployment replicas and master node selector configurable.

Related issue(s)

Fixes #

Signed-off-by: Dong Beiqing <350758787@qq.com>
Copy link

codecov bot commented May 20, 2024

Codecov Report

Attention: Patch coverage is 40.00000% with 24 lines in your changes are missing coverage. Please review.

Project coverage is 62.72%. Comparing base (df3b290) to head (569877c).
Report is 1 commits behind head on main.

Files Patch % Lines
...stermanagercontroller/clustermanager_controller.go 28.57% 10 Missing ⚠️
...lers/klusterletcontroller/klusterlet_controller.go 33.33% 8 Missing ⚠️
...sterletcontroller/klusterlet_cleanup_controller.go 40.00% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #468      +/-   ##
==========================================
+ Coverage   62.70%   62.72%   +0.01%     
==========================================
  Files         136      136              
  Lines       11558    11573      +15     
==========================================
+ Hits         7248     7259      +11     
- Misses       3541     3546       +5     
+ Partials      769      768       -1     
Flag Coverage Δ
unit 62.72% <40.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Dong Beiqing <350758787@qq.com>
Signed-off-by: Dong Beiqing <350758787@qq.com>
Signed-off-by: Dong Beiqing <350758787@qq.com>
@qiujian16
Copy link
Member

/assign @zhiweiyin318

pkg/cmd/hub/operator.go Outdated Show resolved Hide resolved
pkg/operator/helpers/helpers.go Outdated Show resolved Hide resolved
Signed-off-by: Dong Beiqing <350758787@qq.com>
@zhiweiyin318
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm label May 21, 2024
Signed-off-by: Dong Beiqing <350758787@qq.com>
@openshift-ci openshift-ci bot removed the lgtm label May 21, 2024
@dongbeiqing91
Copy link
Contributor Author

@zhiweiyin318 I changed controlPlaneNodeLabels to controlPlaneNodeLabelSelector, please review this PR again. Thanks

@zhiweiyin318
Copy link
Member

zhiweiyin318 commented May 21, 2024

@promid the value of the flag controlPlaneNodeLabelSelector is label not labelSelector, so is there a reason why use selector here ?
forget the comment. it is string now.

@zhiweiyin318
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm label May 21, 2024
@qiujian16
Copy link
Member

/approve

Copy link
Contributor

openshift-ci bot commented May 21, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: promid, qiujian16

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 22da639 into open-cluster-management-io:main May 21, 2024
14 checks passed
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants