Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 update sdk-go #469

Merged
merged 1 commit into from
May 21, 2024
Merged

Conversation

skeeey
Copy link
Member

@skeeey skeeey commented May 20, 2024

Summary

Update sdk-go to support

  • Cert rotation for MQTT client
  • Verify TLS with host's ca set for MQTT client

Related issue(s)

Fixes #

Signed-off-by: Wei Liu <liuweixa@redhat.com>
@openshift-ci openshift-ci bot requested review from jnpacker and qiujian16 May 20, 2024 08:46
Copy link

codecov bot commented May 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 62.70%. Comparing base (df3b290) to head (a5d345d).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #469   +/-   ##
=======================================
  Coverage   62.70%   62.70%           
=======================================
  Files         136      136           
  Lines       11558    11558           
=======================================
  Hits         7248     7248           
  Misses       3541     3541           
  Partials      769      769           
Flag Coverage Δ
unit 62.70% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@skeeey
Copy link
Member Author

skeeey commented May 20, 2024

/assign @qiujian16

@qiujian16
Copy link
Member

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm label May 21, 2024
Copy link
Contributor

openshift-ci bot commented May 21, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qiujian16, skeeey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 92a2c91 into open-cluster-management-io:main May 21, 2024
15 checks passed
@skeeey skeeey deleted the ug branch May 30, 2024 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants