🐛 Regenerate the hub kubeconfig secret if the cluster name of the current context changes #473
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/cc @elgnay @qiujian16 |
|
/hold |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #473 +/- ##
==========================================
- Coverage 62.72% 62.71% -0.01%
==========================================
Files 136 136
Lines 11573 11578 +5
==========================================
+ Hits 7259 7261 +2
- Misses 3546 3549 +3
Partials 768 768
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
zhujian7
force-pushed
the
rebootstrap-clusterinfo
branch
from
8513589 to
657dc12
Compare
qiujian16
reviewed
May 22, 2024
…nt context changes Signed-off-by: zhujian <jiazhu@redhat.com>
zhujian7
force-pushed
the
rebootstrap-clusterinfo
branch
from
657dc12 to
ad2f9e0
Compare
|
FYI @xuezhaojun this should also be considered in your PR |
elgnay
reviewed
May 23, 2024
pkg/registration/spoke/spokeagent.go
Outdated
| @@ -236,11 +236,12 @@ func (o *SpokeAgentConfig) RunSpokeAgentWithSpokeInformers(ctx context.Context, | |||
| managementKubeClient, 10*time.Minute, informers.WithNamespace(o.agentOptions.ComponentNamespace)) | |||
|
|
|||
| // create a kubeconfig with references to the key/cert files in the same secret | |||
| srever, proxyURL, caData, err := parseKubeconfig(o.registrationOption.BootstrapKubeconfig) | |||
| contextClusterName, srever, proxyURL, caData, err := parseKubeconfig(o.registrationOption.BootstrapKubeconfig) | |||
elgnay
reviewed
May 23, 2024
|
/lgtm |
Signed-off-by: zhujian <jiazhu@redhat.com>
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: qiujian16, zhujian7 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/unhold |
openshift-merge-bot
bot
merged commit 66d4e78
into
open-cluster-management-io:main
14 checks passed
zhujian7
added a commit
to zhujian7/ocm
that referenced
this pull request
Jun 4, 2024
…rent context changes (open-cluster-management-io#473) * Regenerate the hub kubeconfig secret if the cluster name of the current context changes Signed-off-by: zhujian <jiazhu@redhat.com> * Add an integration test Signed-off-by: zhujian <jiazhu@redhat.com> --------- Signed-off-by: zhujian <jiazhu@redhat.com>
openshift-merge-bot bot
pushed a commit
to stolostron/ocm
that referenced
this pull request
Jun 5, 2024
…rent context changes (open-cluster-management-io#473) (#71) * Regenerate the hub kubeconfig secret if the cluster name of the current context changes * Add an integration test --------- Signed-off-by: zhujian <jiazhu@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Related issue(s)
Fixes #