Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 Add appscode to ADOPTERS list #477

Merged

Conversation

tamalsaha
Copy link
Contributor

Summary

Related issue(s)

Fixes #

@openshift-ci openshift-ci bot requested review from jnpacker and qiujian16 May 24, 2024 16:37
Copy link

codecov bot commented May 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 62.71%. Comparing base (66d4e78) to head (65fc6dc).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #477   +/-   ##
=======================================
  Coverage   62.71%   62.71%           
=======================================
  Files         136      136           
  Lines       11578    11578           
=======================================
  Hits         7261     7261           
  Misses       3549     3549           
  Partials      768      768           
Flag Coverage Δ
unit 62.71% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@qiujian16
Copy link
Member

Thanks! need to sign-off the commit by the following command:

git commit --amend -s
git push -f

Signed-off-by: Tamal Saha <tamal@appscode.com>
@tamalsaha
Copy link
Contributor Author

PTAL

@zhujian7
Copy link
Member

/ok-to-test

@qiujian16
Copy link
Member

/approve
/lgtm

Copy link
Contributor

openshift-ci bot commented May 27, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qiujian16, tamalsaha

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 3001883 into open-cluster-management-io:main May 27, 2024
14 checks passed
@tamalsaha tamalsaha deleted the patch-1 branch May 27, 2024 05:00
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants